New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chart update ebpf.plugin #13351
Merged
Merged
Fix chart update ebpf.plugin #13351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
Everything related to data collection
collectors/ebpf
labels
Jul 11, 2022
…/proc, this will not only speed up the sync, but it also reduce cpu usage
…al mutex used when it is necessary to work with apps and cgroup
…al mutex used when it is necessary to work with apps and cgroup (dcstat)
…al mutex used when it is necessary to work with apps and cgroup (fd)
…al mutex used when it is necessary to work with apps and cgroup (oomkill)
…al mutex used when it is necessary to work with apps and cgroup (shm)
…al mutex used when it is necessary to work with apps and cgroup (socket)
…al mutex used when it is necessary to work with apps and cgroup (swap)
…al mutex used when it is necessary to work with apps and cgroup (vfs)
… normal mutex used when it is necessary to work with apps and cgroup (process)
thiagoftsm
requested review from
MrZammler and
underhood
and removed request for
vkalintiris
July 12, 2022 23:05
DShreve2
previously approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs approve.
ilyam8
reviewed
Jul 14, 2022
vlvkobal
reviewed
Jul 14, 2022
vlvkobal
approved these changes
Jul 18, 2022
ilyam8
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13346
This PR is bringing the following changes to remove locks that do not allow chart to be updated correctly:
else
toelse if
insystemd
charts, this will avoid to recreate these charts every iterationapps' and
cgroup` will work more independent.broadcast
andwait
, because they were creating delay to send the messages to netdata on environments testedTest Plan
ebpf.plugin
enabled during few minutes0
:Additional Information
This PR was tested on the following environments:
Map is the memory mode where I had more events, and I still have when my parent was overloaded or updating Tier.
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? ebpf.plugin - Can they see the change or is it an under the hood? If they can see it, where? Due the fact netdata interpolates, it was not visible when a data was not stored on dashboard, but this is visible trough our API. - How is the user impacted by the change? All collected data will be stored in the correct time, unless system is overloaded, but this also affects other plugins. - What are there any benefits of the change? Data quality