New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uninstaller documentation. #13627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/packaging
Packaging and operating systems support
labels
Sep 5, 2022
thiagoftsm
previously approved these changes
Sep 5, 2022
Dim-P
reviewed
Sep 6, 2022
packaging/installer/UNINSTALL.md
Outdated
kickstart script (internally, the kickstart script also uses this uninstaller script, it just handles the process | ||
outlined below for you). | ||
|
||
This uninstaller script is self-contained other than requiring a `.environment` file that was generated ruing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ferroin Did you mean to say "was generated during installation" here?
DShreve2
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments for consistency; approved!
Co-authored-by: DShreve2 <david@netdata.cloud>
DShreve2
approved these changes
Sep 8, 2022
Dim-P
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This properly documents the preferred uninstallation method, as well as tidying up the existing documentation as a fallback method.
Test Plan
n/a