Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(updater): don't produce any output if static update completed successfully #14058

Merged
merged 1 commit into from Nov 28, 2022
Merged

fix(updater): don't produce any output if static update completed successfully #14058

merged 1 commit into from Nov 28, 2022

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Nov 28, 2022

Summary

Fixes: #12824

Test Plan

Run the updater script with --no-updater-self-update --non-interactive --force-update, check the output and exit code.

$ ./netdata-updater.sh --no-updater-self-update --non-interactive --force-update
$ echo $?
0
Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 requested a review from Ferroin as a code owner November 28, 2022 14:47
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Nov 28, 2022
@ilyam8 ilyam8 requested a review from Dim-P November 28, 2022 14:53
@ilyam8 ilyam8 mentioned this pull request Nov 28, 2022
Closed
@ilyam8 ilyam8 merged commit 2033fb1 into netdata:master Nov 28, 2022
@ilyam8 ilyam8 deleted the fix_updater_static_output_on_success branch November 28, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferroin Ferroin Ferroin approved these changes

@Dim-P Dim-P Dim-P approved these changes

Assignees
No one assigned
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Noisy update cron job
3 participants
@ilyam8 @Ferroin @Dim-P