Add Amazon Linux 2 to CI and platform support. #14599
Conversation
github-actions
bot
added
area/ci
area/docs
area/packaging
|
This pull request has been mentioned on Netdata Community Forums. There might be relevant details there: https://community.netdata.cloud/t/amazonlinux2-installation-is-there-an-rpm/3524/10 |
|
Looks good, build passes, let's merge it to double down on it via our kickstart |
Co-authored-by: Tasos Katsoulas <12612986+tkatsoulas@users.noreply.github.com>
|
@netdata/agent-sre Do you require any testing to be done using an Amazon Linux 2 VM as part of this PR? |
If you’re offering to test it, that would be greatly appreciated. Simply building the packages locally and confirming at a basic level that they work as they should once installed is sufficient here (the plan is to do more testing once this is merged, and then probably bump AL2 to Core tier support some time after v1.39.0). |
I don't think I still have access to that VM but I can set one up again and report results here. |
|
@tkatsoulas: When do you think this can be merged? |
|
@sashwathn Theoretically today if we can get the approvals. |
|
From my end, still pending; a last code inspection on |
|
Done, LGTM, my suggestion, merge it on Monday |
|
Thanks @tkatsoulas @Ferroin! |
There was a problem hiding this comment.
Just tested a local build and a build of native packages locally on an Amazon Linux 2 VM. I didn't notice any errors, LGTM!
@Ferroin I suppose logs like these are expected:
warning: File listed twice: /etc/netdata/netdata.conf
warning: File listed twice: /usr/lib/netdata
warning: File listed twice: /usr/lib/netdata/conf.d
warning: File listed twice: /usr/lib/netdata/conf.d/apps_groups.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/ap.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/apcupsd.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/example.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/libreswan.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/nut.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/opensips.conf
warning: File listed twice: /usr/lib/netdata/conf.d/charts.d/sensors.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/cachestat.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/dcstat.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/disk.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/ebpf_kernel_reject_list.txt
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/fd.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/filesystem.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/hardirq.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/mdflush.conf
warning: File listed twice: /usr/lib/netdata/conf.d/ebpf.d/mount.conf
...
There was also a bogus date in %changelog showing up somewhere, but I didn't take note of where exactly.
Yes, all of those should be fixed by #13927 |
Summary
This initial PR adds it in the Intermediate support tier due to the limited testing so far. The plan is to migrate it to Core tier once we have solid evidence that it works reliably, likely some time after the release of v1.39.0.
Test Plan
New CI passes on this PR.
Any further testing requires this to be merged and wait for nightlies to be published.
Additional Information
Resolves: #14199
This also includes a number of other minor bug fixes, mostly related to the installer and updater code.