update agent telemetry url to be cloud function instead of posthog #15085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/packaging
andrewm4894
requested review from
tkatsoulas,
Ancairon,
Ferroin,
thiagoftsm and
vkalintiris
as code owners
andrewm4894
changed the title
thiagoftsm
approved these changes
May 23, 2023
There was a problem hiding this comment.
After a chat with @andrewm4894 we could confirm PR is working as expected, LGTM!
MrZammler
approved these changes
May 24, 2023
|
@netdata/agent-sre are some of the checks here stuck perhaps? |
|
I am going to wait until Monday to merge this so can watch it close once its merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace posthog with a gcp cloud function for agent events that do not need to be in posthog.
daemon\anonymous-statistics.sh.inpackaging\installer\kickstart.shTest Plan
Validate that events are flowing in as expected (into BigQuery via the cloud function) from agents running this feature branch.
Additional Information
For users: How does this change affect me?
internal slack thread with some more info and background