Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health: remove "families" from alarms config #15086

Merged
merged 2 commits into from Jun 1, 2023

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented May 23, 2023

Summary

Follow-up on #14982 and part of netdata/product#3118 and #15030.


This PR modifies health configurations:

  • removes "families: *"
  • replaces the rest of the families with chart labels.

Note This PR doesn't update documentation.


@MrZammler we usually align all the entities, which means we need to re-align all the alarms that use "chart labels" because that's the longest entity.

I think that we can rename it to just "labels":

  • one word => shorter => looks neater.
  • no re-aligning needed.
  • "host labels" is used very rare (only once actually), so there won't be any confusion.
Test Plan

The changes are straightforward, no manual testing is needed, just a visual review of the changes.

Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 changed the title remove "families: *" health: remove "families" from alarms config May 23, 2023
@thiagoftsm
Copy link
Contributor

Hello @ilyam8 ,

Let us follow @MrZammler suggestion and update documentation saying that we are going to deprecated the family.

Best regards!

@MrZammler
Copy link
Contributor

Hello @ilyam8 ,

Let us follow @MrZammler suggestion and update documentation saying that we are going to deprecated the family.

Best regards!

Hey Thiago, it's already there https://learn.netdata.cloud/docs/alerts-and-notifications/configure-alerts#alarm-line-families . Should we add something more?

@thiagoftsm
Copy link
Contributor

Hello @ilyam8 ,
Let us follow @MrZammler suggestion and update documentation saying that we are going to deprecated the family.
Best regards!

Hey Thiago, it's already there https://learn.netdata.cloud/docs/alerts-and-notifications/configure-alerts#alarm-line-families . Should we add something more?

I took a look and I think this is enough.

@ilyam8 ilyam8 merged commit 5e02129 into netdata:master Jun 1, 2023
125 checks passed
@ilyam8 ilyam8 deleted the health_rm_families_from_conf branch June 1, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants