Provide necessary permission for the kickstart to run the netdata-updater script #15132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
|
AFA I can tell the debian packages are not affected by this issue. |
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
tkatsoulas
force-pushed
the
patch-auto-updates-fix
branch
from
f2a17ae
to
33fbf05
Compare
|
This |
Ferroin
reviewed
Jun 1, 2023
Co-authored-by: Austin S. Hemmelgarn <austin@netdata.cloud>
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Ferroin
approved these changes
Jun 1, 2023
|
Static build failures are unrelated to this PR and should be fixed by netdata/helper-images#210. |
No problem on Debian. |
tkatsoulas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment the updater script on the native packages is installed with ownership
root netdata. Kickstart need to have root access to verify the existence of the netdata-updater script and run it.Test Plan
Download kickstart script from this PR.
Further testing.
Enforce other auto update types
--auto-update-type Specify a particular scheduling type for auto-updates (valid types: systemd, interval, crontab)Additional Information
For users: How does this change affect me?