send EXIT before exiting in freeipmi and debugfs plugins #15140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
MrZammler
previously approved these changes
Jun 5, 2023
thiagoftsm
previously approved these changes
Jun 5, 2023
MrZammler
approved these changes
Jun 5, 2023
thiagoftsm
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The same change we did for charts.d.plugin.
Sometimes external processes become a zombie. This is likely because Netdata's main process doesn't handle
SIGCHLD(this signal is simply ignored) and we rely on the read parser to fail. But sometimes it doesn't work and the parser gets stuck in parser_next->fgets().Some external plugins periodically exit (e.g. freeipmi every 4 hours, debugfs every 24 hours), and every time they exit there is a chance to get a zombie process 馃
This PR addresses only this case, the (alleged) root cause (ignoring
SIGCHLD) will be fixed in #15113.Test Plan
ci.
Additional Information
For users: How does this change affect me?