Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted kickstart script improvements. #15243

Merged
merged 2 commits into from Jun 28, 2023
Merged

Assorted kickstart script improvements. #15243

merged 2 commits into from Jun 28, 2023

Conversation

Ferroin
Copy link
Member

@Ferroin Ferroin commented Jun 22, 2023 •
edited

Summary
  • Provide a more complete error message for unrecognized options, making more specific suggestions about probable common cases of users passing them.
  • Added exceptions for a couple of common and harmless unrecognized options so that they are just ignored instead of being treated as a fatal error. A warning is still issued for these options.
  • Added a bit more clarity in a couple of other messages.
  • Consolidated the URLs used in the script into a separate section from the other constants.
Test Plan

Only thing to check is that options such as --, --accept, or --yes are ignored instead of failing the install.

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Jun 22, 2023
@Ferroin Ferroin marked this pull request as ready for review June 22, 2023 16:49
@Ferroin Ferroin requested a review from tkatsoulas as a code owner June 22, 2023 16:49
@Ferroin Ferroin requested a review from a team June 22, 2023 16:50
@Ferroin Ferroin merged commit 625b929 into netdata:master Jun 28, 2023
128 checks passed
@Ferroin Ferroin deleted the kickstart-cleanup branch June 28, 2023 11:55
Ancairon pushed a commit that referenced this pull request Jul 3, 2023
@Ferroin @Ancairon
Assorted kickstart script improvements. (#15243)
d53286b 
* Further clarify a number of errors and warnings in the kickstart script.

* Ignore and warn on a handful of safe common unrecognized options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@tkatsoulas tkatsoulas Awaiting requested review from tkatsoulas

Assignees
No one assigned
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ferroin @ilyam8 @thiagoftsm