Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health: respect overriding nc binary for IRC notifications #15310

Merged
merged 1 commit into from Jul 5, 2023
Merged

health: respect overriding nc binary for IRC notifications #15310

merged 1 commit into from Jul 5, 2023

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jul 4, 2023 •
edited

Summary

Fixes: #15172
Closes: #15173

Test Plan

Test changes using the alarm-test.sh script.

Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 marked this pull request as ready for review July 4, 2023 16:15
thiagoftsm
thiagoftsm approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shellcheck passed OK and logic does not have error, so I am approving without test, because I do not have IRC, LGTM!

@ilyam8 ilyam8 merged commit 1e18151 into netdata:master Jul 5, 2023
128 checks passed
@ilyam8 ilyam8 deleted the feat_health_notification_override_nc branch July 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrZammler MrZammler MrZammler approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@Ferroin Ferroin Awaiting requested review from Ferroin Ferroin is a code owner

Assignees
No one assigned
Labels
area/health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: TLS support for IRC notifications
3 participants
@ilyam8 @MrZammler @thiagoftsm