New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash table charts #15323
Merged
Merged
Hash table charts #15323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
requested review from
Ferroin,
tkatsoulas,
vkalintiris,
andrewm4894 and
Ancairon
as code owners
July 7, 2023 01:36
github-actions
bot
added
area/packaging
Packaging and operating systems support
area/docs
area/web
area/collectors
Everything related to data collection
area/tests
area/build
Build system (autotools and cmake).
collectors/ebpf
labels
Jul 7, 2023
thiagoftsm
force-pushed
the
hash_table_charts
branch
from
July 14, 2023 22:40
9272175
to
94c98b9
Compare
github-actions
bot
removed
area/web
area/tests
area/build
Build system (autotools and cmake).
area/docs
labels
Jul 14, 2023
thiagoftsm
force-pushed
the
hash_table_charts
branch
from
July 16, 2023 21:58
c6eb03b
to
da21afb
Compare
thiagoftsm
requested review from
MrZammler,
underhood and
stelfrag
and removed request for
Ferroin,
andrewm4894 and
tkatsoulas
July 18, 2023 03:06
thiagoftsm
force-pushed
the
hash_table_charts
branch
2 times, most recently
from
July 18, 2023 21:08
cd92803
to
c143c65
Compare
… is given and also adds beginning of function enable
…voiding possible issues in the future.
…for a more generic place; modify hash_table_stats one more time to do a more generic function
…end calls to read control table (cachestat)
…end calls to read control table (dcstat)
…end calls to read control table (fd)
thiagoftsm
force-pushed
the
hash_table_charts
branch
from
July 18, 2023 23:46
c143c65
to
a06e022
Compare
MrZammler
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on an Debian VM, appears to work fine! I have the charts ok!
underhood
approved these changes
Jul 20, 2023
I did only quick basic testing on this one. Approving to unblock (if you need deeper review ignore this approval) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/collectors
Everything related to data collection
area/packaging
Packaging and operating systems support
collectors/ebpf
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is adding monitoring information for elements inside hash tables.
This PR is actually completely blocked by #15214
Test Plan
/etc/netdata/ebpf.d.conf
and also enable integration with appslibbpf
issue (We still can have for some distributions like Gentoo):Additional Information
This PR was tested on:
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? eBPF plugin - Can they see the change or is it an under the hood? If they can see it, where? They will have more charts in netdata monitoring section - How is the user impacted by the change? eBPF.plugin will store more data inside hash table. - What are there any benefits of the change? A better understanding about what is happening in your host.