fix the calculation of incremental-sum #15468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ktsaou
commented
Jul 20, 2023
•
ktsaou
commented
- when calculating incremental sum, if the data have flat steps, the calculation was missing the delta
- when planning the query to select the right tier, assume the minimum required is 400 points, to pick the tier that will provide at least this resolution. This should improve the precision of metrics correlations, anomaly advisor, badges and alerts.
|
@andrewm4894 the second bullet should fix the issue with the precision metrics correlations and anomaly rate that ask for 1 points. So, now the query planner will try to find a tier that can provide around 400 points for the time-frame requests and selected the one that is closer to 400. |
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Aug 1, 2023
* fix the calculation of incremental-sum * for query planning use at least 400 points (cherry picked from commit d36fb28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.