Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small readme icon fix #15583

Merged
merged 1 commit into from Jul 27, 2023
Merged

small readme icon fix #15583

merged 1 commit into from Jul 27, 2023

Conversation

andrewm4894
Copy link
Contributor

@andrewm4894 andrewm4894 commented Jul 27, 2023

Summary

seems like this emoji is not rendering on gh correct so this pr just swaps it out with one that does.

broken: https://github.com/netdata/netdata#information_source-what-does-the-anonymous-telemetry-collected-by-netdata-entail

fixed: https://github.com/netdata/netdata/tree/small-readme-icon-fix#mag_right-what-does-the-anonymous-telemetry-collected-by-netdata-entail

replace

image

with this

image

Test Plan
Additional Information
For users: How does this change affect me?

@andrewm4894 andrewm4894 marked this pull request as ready for review July 27, 2023 13:38
@ilyam8
Copy link
Member

ilyam8 commented Jul 27, 2023

It is not broken

Screenshot 2023-07-27 at 16 39 48

@andrewm4894
Copy link
Contributor Author

Maybe just for me or on chrome or something. I know is a supported one. Will see if just fixes itself maybe.

I'll ask in slack

Copy link
Contributor

@Dim-P Dim-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not broken for me either, but I prefer the new one :) .

@ilyam8 ilyam8 merged commit b8b55f4 into master Jul 27, 2023
123 checks passed
@ilyam8 ilyam8 deleted the small-readme-icon-fix branch July 27, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants