Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential crash bug. #15605

Merged
merged 3 commits into from Jul 28, 2023
Merged

fix potential crash bug. #15605

merged 3 commits into from Jul 28, 2023

Conversation

icy17
Copy link
Contributor

@icy17 icy17 commented Jul 28, 2023

Check that its argument is not NULL before using SSL_CTX_set_options.

If the parameter 1 of SSL_CTX_set_options is NULL, there is a null-dereference which will cause crash. So there should be a check against NULL in the code to avoid the problem.

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

@thiagoftsm
Copy link
Contributor

Hello @icy17 ,

Please, sign our CLA for we have conditions to accept your contribution.

Best regards!

@icy17
Copy link
Contributor Author

icy17 commented Jul 28, 2023

Hi @thiagoftsm,
Thank you for reminding me! I just signed the CLA.

Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
@ktsaou ktsaou merged commit b2ae925 into netdata:master Jul 28, 2023
128 checks passed
@icy17
Copy link
Contributor Author

icy17 commented May 15, 2024

Hi! Thanks for merging my pull requests!
I noticed these PR addresse potential security issues. I'm wondering if it would be appropriate to apply for CVEs for these bugs? Could you let me know if that's possible and what steps I should take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants