Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer titles, families, units and priorities from collected charts #15614

Merged
merged 3 commits into from Aug 3, 2023

Conversation

ktsaou
Copy link
Member

@ktsaou ktsaou commented Jul 28, 2023

Contexts have a few values that are inherited from instances:

  1. title
  2. family
  3. units
  4. priority
  5. chart_type

Before this PR, actively collected instances and archived instances were equally competing for setting them at the context level.

After this PR, the collected instances win. When there is a match, then we merge families with [x].

@ktsaou
Copy link
Member Author

ktsaou commented Aug 1, 2023

@ilyam8 shall we merge this?

@ktsaou ktsaou merged commit 72549b3 into netdata:master Aug 3, 2023
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant