Add dependencies for systemd journal plugin. #15747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
ralphm
previously approved these changes
Aug 4, 2023
Co-authored-by: Ralph Meijer <ralphm@ik.nu>
tkatsoulas
approved these changes
Aug 4, 2023
MrZammler
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds code to the dependency handling scripts to take care of the systemd-journal plugin’s dependencies.
Support for Gentoo and Arch takes advantage of the fact that the ssystemd packages on those systems include the required libraries and header files, so we can simply rely on the configure script’s auto-detection to correctly identify if we should build the systemd-journal plugin on those platforms.
Test Plan
CI passes on this PR (confirms that the package names we’re pulling in here are valid).
Attempt to install using the script from this PR for dependency handling. On supported platforms, it should build the
systemd-journalplugin by default instead of not building it by default.Additional Information
Resolves: #15745
Also sorts the dependency lists for the per-distro scripts that are being modified.