Improve dyncfg exit #15824
Merged
Improve dyncfg exit #15824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underhood
requested review from
MrZammler and
ilyam8
and removed request for
vkalintiris
thiagoftsm
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
The PR reached the goal:
[root@archlinux netdata]# grep DYNCFG /var/log/netdata/*
/var/log/netdata/error.log:2023-08-17 00:01:14: netdata INFO : DYNCFG : (0250@libnetdata/threads/t:netdata_thread_): thread created with task id 26684
/var/log/netdata/error.log:2023-08-17 00:01:14: netdata INFO : DYNCFG : (0210@libnetdata/threads/t:thread_set_name): set name of thread 26684 to DYNCFG
/var/log/netdata/error.log:2023-08-17 00:07:58: netdata INFO : MAIN : (0671@daemon/main.c :cancel_main_thr): EXIT: Stopping main thread: DYNCFG
/var/log/netdata/error.log:2023-08-17 00:07:58: netdata INFO : DYNCFG : (0895@libnetdata/dyn_conf/:dyncfg_cleanup ): cleaning up...
/var/log/netdata/error.log:2023-08-17 00:07:58: netdata INFO : DYNCFG : (0176@libnetdata/threads/t:thread_cleanup ): thread with task id 26684 finished
/var/log/netdata/error.log:2023-08-17 00:16:31: netdata INFO : DYNCFG : (0250@libnetdata/threads/t:netdata_thread_): thread created with task id 27116
/var/log/netdata/error.log:2023-08-17 00:16:31: netdata INFO : DYNCFG : (0210@libnetdata/threads/t:thread_set_name): set name of thread 27116 to DYNCFG
/var/log/netdata/error.log:2023-08-17 00:26:14: netdata INFO : MAIN : (0671@daemon/main.c :cancel_main_thr): EXIT: Stopping main thread: DYNCFG
/var/log/netdata/error.log:2023-08-17 00:26:14: netdata INFO : DYNCFG : (0895@libnetdata/dyn_conf/:dyncfg_cleanup ): cleaning up...
/var/log/netdata/error.log:2023-08-17 00:26:14: netdata INFO : DYNCFG : (0176@libnetdata/threads/t:thread_cleanup ): thread with task id 27116 finishedLGTM!
stelfrag
approved these changes
Aug 17, 2023
Ferroin
pushed a commit
that referenced
this pull request
Aug 22, 2023
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Aug 23, 2023
(cherry picked from commit cec38dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #15821
Cherry picks some of the fixes from other PRs to merge it sooner
Test Plan
You should not see
2023-08-16 17:59:04: netdata ERROR : MAIN : Main thread DYNCFG takes too long to exit. Giving up...on
netdatacli shutdown-agentand netdata should exit fasterAdditional Information
For users: How does this change affect me?