Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proc meminfo cached calculation #15859

Merged
merged 1 commit into from Aug 21, 2023
Merged

fix proc meminfo cached calculation #15859

merged 1 commit into from Aug 21, 2023

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Aug 21, 2023 •
edited

Summary

The bug was introduced in https://github.com/netdata/netdata/pull/15494/files#diff-13ee0998f68cd432ef08fa560ede0b845e8b3100947a8c9e9d70bdc234ffb577

Reported on Discord: negative ram used and huge cached.

KReclaimable includes SReclaimable, we shouldn't sum them but use KReclaimable (available since kernel v4.20) or SReclaimable.

Test Plan
Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 requested a review from MrZammler August 21, 2023 12:05
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/proc labels Aug 21, 2023
thiagoftsm
thiagoftsm approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not observed the cited issues locally.

Dim-P
Dim-P reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Dim-P Dim-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything need updating in st_mem_kernel or st_mem_slab charts due to this PR?

@ilyam8
Copy link
Member Author

ilyam8 commented Aug 21, 2023

Does anything need updating in st_mem_kernel or st_mem_slab charts due to this PR?

No

@ilyam8 ilyam8 merged commit 56479af into netdata:master Aug 21, 2023
137 checks passed
@ilyam8 ilyam8 deleted the fix_meminfo_cached_calculation branch August 21, 2023 14:51
Ferroin pushed a commit that referenced this pull request Aug 22, 2023
@ilyam8 @Ferroin
fix proc meminfo cached calculation (#15859)
f04bf65
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Aug 23, 2023
@ilyam8 @stelfrag
fix proc meminfo cached calculation (netdata#15859)
53ba1e0 
(cherry picked from commit 56479af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrZammler MrZammler MrZammler approved these changes

@Dim-P Dim-P Dim-P approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

Assignees
No one assigned
Labels
area/collectors Everything related to data collection collectors/proc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ilyam8 @MrZammler @Dim-P @thiagoftsm