New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset the obsolete flag on service thread #15892
Reset the obsolete flag on service thread #15892
Conversation
This change appears to somewhat alleviate the case of #15066 |
Noticed on an agent running this patch the following during shutdown:
8 minutes later the same message repeats. Not sure if it's because of this patch or not, will have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR worked as expected when I obsolete a thread in eBPF.plugin, LGTM!
Summary
This PR makes 2 small changes:
The first is if the service thread does not clean a chart (because of timing factors) to re-set the host wide
RRDHOST_FLAG_PENDING_OBSOLETE_CHARTS
flag to re-try on the next iteration.The second change is to execute
rrdset_free
in all memory modes.The goal is to see whether memory usage can be reduced in case of many ephemeral charts.
Test Plan
Additional Information
For users: How does this change affect me?