Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pfsense.md #15894

Merged
merged 2 commits into from Sep 4, 2023
Merged

Update pfsense.md #15894

merged 2 commits into from Sep 4, 2023

Conversation

Ancairon
Copy link
Member

Summary

closes netdata/learn#1774, after an internal discussion we concluded the snippet was needed to be present in this file, due to problems coming up with pfSense plus.

@github-actions github-actions bot added area/packaging Packaging and operating systems support area/docs labels Aug 31, 2023
MrZammler
MrZammler previously approved these changes Aug 31, 2023
@@ -18,6 +18,8 @@ learn_rel_path: "Installation/Install on specific environments"

## Install prerequisites/dependencies

> **Note** The following instructions are meant to be used for the Commmunity Edition of pfSense.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note** The following instructions are meant to be used for the Commmunity Edition of pfSense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you suggest instead, to address the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't make a suggestion on the specific line (line 10), probably a bug, change the naming of this guide to Install Netdata on pfSense CE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkatsoulas removed the added line and changed the title.

@tkatsoulas tkatsoulas merged commit d4c1ace into master Sep 4, 2023
128 checks passed
@ilyam8 ilyam8 deleted the Ancairon-patch-1 branch September 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback]: PFSense+ 23.05.1 - pkg update issue
3 participants