Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted Dockerfile cleanup. #15902

Merged
merged 1 commit into from Sep 5, 2023
Merged

Assorted Dockerfile cleanup. #15902

merged 1 commit into from Sep 5, 2023

Conversation

Ferroin
Copy link
Member

@Ferroin Ferroin commented Sep 1, 2023

Summary
  • Drop old, pointless comments.
  • Reorganize so that invariant layers are first, making build caching more efficient.
Test Plan

Docker CI passes on this PR.

@Ferroin
Assorted Dockerfile cleanup.
ff9a2e5 
- Drop old, pointless comments.
- Reorganize so that invariant layers are first, making build caching
  more efficient.
@Ferroin Ferroin marked this pull request as ready for review September 1, 2023 14:26
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Sep 1, 2023
@Ferroin Ferroin requested a review from a team September 1, 2023 17:33
@tkatsoulas tkatsoulas merged commit 6efd6b7 into netdata:master Sep 5, 2023
130 checks passed
@Ferroin Ferroin deleted the docker-cleanup branch September 5, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dim-P Dim-P Dim-P approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@tkatsoulas tkatsoulas Awaiting requested review from tkatsoulas

Assignees
No one assigned
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ferroin @Dim-P @thiagoftsm @tkatsoulas