Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce workload during cleanup #15919

Merged
merged 3 commits into from Sep 5, 2023
Merged

Reduce workload during cleanup #15919

merged 3 commits into from Sep 5, 2023

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Sep 5, 2023 •
edited

Fixes #15908

Summary
  • Use a new index to make cleanup faster
  • Check less entries per iteration during metadata cleanup
    • A future PR will improve on these even more
Test Plan
  • Start agent
  • Notice CPU spike 30 minutes after restart under Netdata Monitoring section, there is a workers entry --> libuv

Apply the PR and check again

  • CPU spike should be minimal

@stelfrag stelfrag marked this pull request as ready for review September 5, 2023 16:50
thiagoftsm
thiagoftsm approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected, LGTM!

@stelfrag stelfrag merged commit d258177 into netdata:master Sep 5, 2023
137 checks passed
@stelfrag stelfrag deleted the reduce_workload_during_cleanup branch September 5, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrZammler MrZammler MrZammler approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

Assignees
No one assigned
Labels
area/database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Netdata using 100% of one core with nice process
3 participants
@stelfrag @MrZammler @thiagoftsm