Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cgroup charts #15975

Merged
merged 31 commits into from Oct 2, 2023
Merged

Split cgroup charts #15975

merged 31 commits into from Oct 2, 2023

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Sep 15, 2023

Summary

Fixes #14943

This PR is reorganizing the way we are showing our services charts.

Test Plan
  1. Compile this branch on environment that has systemd.
  2. Run and take a look how charts are now shown on dashboard.
Additional Information

This PR was tested on:

Linux Distribution Bare metal / VM Kernel version
Arch Linux Libvirt 6.5.2-arch1-1
Ubuntu 22.04 Libvirt 5.15.0-76-generic
Debian 11 Libvirt 5.10.191-1
For users: How does this change affect me? Describe the PR affects users: - Which area of Netdata is affected by the change? cgroup plugin - Can they see the change or is it an under the hood? If they can see it, where? Yes, when user access dashboard they will have charts inside `systemd` submenu - How is the user impacted by the change? Services are not independent, instead to have they organized in one unique chart - What are there any benefits of the change? Charts better organized.

@thiagoftsm thiagoftsm marked this pull request as draft September 15, 2023 04:12
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/cgroups labels Sep 15, 2023
@thiagoftsm thiagoftsm marked this pull request as ready for review September 15, 2023 20:50
@ilyam8 ilyam8 marked this pull request as draft September 30, 2023 19:43
@github-actions github-actions bot added the area/metadata Integrations metadata label Oct 1, 2023
@ilyam8 ilyam8 marked this pull request as ready for review October 1, 2023 17:00
ilyam8
ilyam8 previously approved these changes Oct 2, 2023
@ilyam8 ilyam8 merged commit 06da204 into netdata:master Oct 2, 2023
142 checks passed
@thiagoftsm thiagoftsm deleted the split_cgroup_charts branch October 2, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection area/metadata Integrations metadata collectors/cgroups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: systemd services should be exposed differently
3 participants