Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings #16006

Merged
merged 1 commit into from Sep 19, 2023
Merged

Fix compilation warnings #16006

merged 1 commit into from Sep 19, 2023

Conversation

stelfrag
Copy link
Collaborator

Summary

Fix compilation warnings when compiling with NETDATA_INTERNAL_CHECKS or NETDATA_DEV_MODE

@stelfrag stelfrag marked this pull request as ready for review September 19, 2023 08:51
@vkalintiris
Copy link
Contributor

@stelfrag okay to merge this at the end of the day? I and @Ferroin are both modifying the #15996 PR and CI won't run if there are merge conflicts.

@stelfrag
Copy link
Collaborator Author

@stelfrag okay to merge this at the end of the day? I and @Ferroin are both modifying the #15996 PR and CI won't run if there are merge conflicts.

okay!

thiagoftsm
thiagoftsm approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR was compiled without warnings, LGTM!

@thiagoftsm
Copy link
Contributor

@stelfrag okay to merge this at the end of the day? I and @Ferroin are both modifying the #15996 PR and CI won't run if there are merge conflicts.

PR is ready to be merged @vkalintiris !

@vkalintiris
Copy link
Contributor

@stelfrag we can actually merge this now.

@stelfrag stelfrag merged commit f07a553 into netdata:master Sep 19, 2023
137 checks passed
@stelfrag stelfrag deleted the fix_compilation_warnings branch September 19, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkalintiris vkalintiris vkalintiris approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

Assignees
No one assigned
Labels
area/collectors Everything related to data collection area/database area/streaming collectors/freeipmi collectors/nfacct collectors/plugins.d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stelfrag @vkalintiris @thiagoftsm