Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] MQTT ARM fix #16154

Merged
merged 2 commits into from Oct 10, 2023
Merged

[BUGFIX] MQTT ARM fix #16154

merged 2 commits into from Oct 10, 2023

Conversation

underhood
Copy link
Contributor

@underhood underhood commented Oct 9, 2023

Summary

Fixes #14696

Test Plan

Needs to be well tested (recommending to test on high load node before merging) as this modifies code that is core.

TLDR:

  1. verify this actually fixes bug mentioned above
  2. to be paranoid (as ACLK is critical component) verify it runs well preferably on a node with high cloud/agent (ACLK) traffic.
Additional Information
For users: How does this change affect me?

@underhood underhood requested review from ilyam8 and stelfrag and removed request for Ferroin October 9, 2023 15:16
@ilyam8
Copy link
Member

ilyam8 commented Oct 9, 2023

Static arm7l build no longer crashes on an aarch64 node after this PR.

@underhood underhood changed the title MQTT ARM fix [BUGFIX] MQTT ARM fix Oct 9, 2023
@ilyam8 ilyam8 merged commit 2918465 into netdata:master Oct 10, 2023
139 checks passed
@underhood underhood deleted the mqtt_arm7_fix branch October 13, 2023 07:26
@lara29
Copy link

lara29 commented Oct 16, 2023

@underhood thank you for fixing this problem, we're looking forward to it. Do you know when this fix will be released as part of an official release?

@ilyam8
Copy link
Member

ilyam8 commented Oct 16, 2023

@lara29 v1.43.0 is scheduled for today.

@lara29
Copy link

lara29 commented Oct 16, 2023

@ilyam8 great news, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Netdata crashed with program terminated with signal SIGBUS, Bus error in arm64 using armv7 build
4 participants