Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings #16158

Merged
merged 1 commit into from Oct 10, 2023
Merged

Fix compilation warnings #16158

merged 1 commit into from Oct 10, 2023

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Oct 10, 2023 •
edited

Summary
  • Fix compilation warnings and coverity issues
    • CID 403053: Structurally dead code (UNREACHABLE)
      When not compiling with dyncfg enabled
  • Drop warning message when parent does not support dynamic config

@stelfrag
Fix compilation warnings
c90e911 
Drop warning when parent is not accepting job status updates
@stelfrag stelfrag marked this pull request as ready for review October 10, 2023 10:50
thiagoftsm
thiagoftsm approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected, LGTM!

@stelfrag stelfrag merged commit 7644910 into netdata:master Oct 10, 2023
140 checks passed
@stelfrag stelfrag deleted the fix_compilation_warnings branch October 10, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrZammler MrZammler MrZammler approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@underhood underhood Awaiting requested review from underhood

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

Assignees
No one assigned
Labels
area/collectors Everything related to data collection area/database area/streaming area/web collectors/plugins.d collectors/systemd-journal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stelfrag @MrZammler @thiagoftsm