Fix netdata-uninstaller; blindly deletes NETDATA_PREFIX env var #16167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
|
We need to:
|
tkatsoulas
commented
Oct 11, 2023
| @@ -733,20 +733,20 @@ rm_file /etc/cron.daily/netdata-updater | |||
| rm_file /etc/cron.d/netdata-updater | |||
|
|
|||
|
|
|||
| if [ -n "${NETDATA_PREFIX}" ] && [ -d "${NETDATA_PREFIX}" ]; then | |||
| if [ -n "${NETDATA_PREFIX}" ] && [ -d "${NETDATA_PREFIX}" ] && [ "netdata" = "$(basename "$NETDATA_PREFIX")" ] ; then | |||
| rm_dir "${NETDATA_PREFIX}" | |||
There was a problem hiding this comment.
covers cases like static installs and macos
tkatsoulas
commented
Oct 11, 2023
| rm_dir "${NETDATA_PREFIX}" | ||
| else | ||
| rm_file "/usr/sbin/netdata" |
There was a problem hiding this comment.
All of this block
Linux build from source + FreeBSD
ilyam8
reviewed
Oct 11, 2023
ilyam8
approved these changes
Oct 11, 2023
tkatsoulas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We noticed that there might be cases in which the NETDATA_PREFIX (during installation) might point to a system wide folder. We need to avoid causes like this by checking the suffix of the path (to be a netdata folder)
This issue affects all "from source" installations that use
--install-no-prefix.Test Plan
Cases: Build-only (you need to instruct local kickstart to point to a local tarball), build from source, static builds
What to check
Install and uninstall; check the folder the uninstaller will remove, they must be just netdata folder