Fix Discord webhook payload #16257
Merged
Fix Discord webhook payload #16257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchaos
requested review from
Ferroin,
thiagoftsm and
MrZammler
as code owners
|
|
ilyam8
approved these changes
Oct 22, 2023
thiagoftsm
approved these changes
Oct 22, 2023
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit b549f59)
Closed
tkatsoulas
pushed a commit
that referenced
this pull request
Oct 26, 2023
(cherry picked from commit b549f59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes a trailing comma to make the Discord/Slack payload valid JSON.
Otherwise the Discord notification is not sent.
Test Plan
https://learn.netdata.cloud/docs/alerting/notifications/agent-dispatched-notifications/discord#test-notification
Additional Information
Fixes #16256
For users: How does this change affect me?
Discord notifications should be sent again.