Replace distutils with packaging for version #16259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
ilyam8
reviewed
Oct 23, 2023
collectors/python.d.plugin/python_modules/bases/FrameworkServices/UrlService.py
Outdated
Show resolved
Hide resolved
ilyam8
reviewed
Oct 23, 2023
collectors/python.d.plugin/python_modules/bases/FrameworkServices/UrlService.py
Show resolved
Hide resolved
ilyam8
approved these changes
Oct 23, 2023
tkatsoulas
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16254
Replaces
distutils.versionwithpackaging.versionas suggested in https://peps.python.org/pep-0632/Test Plan
Make sure python.d.plugin continues to work when it uses the
UrlService.Additional Information
For users: How does this change affect me?