New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set "HOME" after switching to netdata user #16548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/packaging
Packaging and operating systems support
area/build
Build system (autotools and cmake).
labels
Dec 5, 2023
ilyam8
requested review from
Ferroin,
tkatsoulas,
thiagoftsm and
vkalintiris
as code owners
December 6, 2023 11:37
vkalintiris
previously approved these changes
Dec 6, 2023
ilyam8
commented
Dec 6, 2023
thiagoftsm
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On FreeBSD 13.2-RELEASE-p7
everything worked as expected, LGTM!
Merged
vkalintiris
approved these changes
Dec 7, 2023
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 9fdf1c9)
Merged
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 9fdf1c9)
tkatsoulas
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 9fdf1c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
Build system (autotools and cmake).
area/daemon
area/packaging
Packaging and operating systems support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #16511
I installed Netdata on FreeBSD using
netdata-installer.sh
and it failed to startservice netdata start
:The problem is:
This happens before switching to the
netdata
user, so we are theroot
user. This means the value is incorrect, it is not "HOME" netdata. If you check[directory] home =
innetdata.conf
on your instances, you will see that it is/root
. The "HOME" environment value is/root
on Linux and/
on FreeBSD. And the check function fails in FreeBSD => fatal.The fix is:
Test Plan
Install on FreeBSD using
netdata-installer.sh
and make sure:service netdata status/stop/start/restart
works.[directories] home
innetdata.conf
is set to the home directory of the user that Netdata is configured to run as (default:netdata
).Additional Information
For users: How does this change affect me?