Make the systemd-journal mandatory package on Centos 7 and Amazon linux 2 #16562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
…ux 2 Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
github-actions
bot
added
the
area/packaging
tkatsoulas
changed the title
Ferroin
approved these changes
Dec 7, 2023
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 11, 2023
…ux 2 (netdata#16562) --------- Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud> (cherry picked from commit 35403d6)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch the package dependencies on centos 7 and Amazon linux 2; make the systemd-journal plugin hard dependency
In 1f19d17 I removed the check (about centos ver 6) is this a garbage or am I missing something?
Test Plan
Build native packages for CentOS 7 and try to install them without specifying the systemd-journal plugin, it should complain.
Additional Information
For users: How does this change affect me?