Shutdown dbengine event loop properly #16658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Unittest is working:
....
labels1 (copied) entries found 5 (should be 5)
0 errors found
time=2023-12-22T16:48:17.548+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="SQLite database :memory: initialization"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Entry cpu.cpu inserted"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Entry cpu.cpu inserted"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Entry cpu.cpu updated"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context start after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context end after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Entry cpu.cpu updated"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context start after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context end after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context start after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context end after insert"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Entry cpu.cpu deleted"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context start after delete"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="List context end after delete"
time=2023-12-22T16:48:17.549+00:00 comm=netdata source=daemon level=info tid=351 thread=MAIN msg="Closing context SQLite database"
UUID: failed 0 out of 100000 tests.
ALL TESTS PASSEDAnd PR is working as expected, LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Jan 31, 2024
* Shutdown dbengine event loop properly * Adjust messages (cherry picked from commit 28ef054)
Merged
tkatsoulas
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Shutdown dbengine event loop properly * Adjust messages (cherry picked from commit 28ef054)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New opcode to properly shutdown dbengine event loop