Improve container detection logic for edit-config. #16825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
ilyam8
reviewed
Jan 22, 2024
ilyam8
approved these changes
Jan 22, 2024
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit fc7f7be)
Merged
tkatsoulas
pushed a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit fc7f7be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/run/.containerenv, which is used by modern versions of Podman and some other OCI stacks to signal that the environment is a container.containerto be set topodman(some images override it), and not require it to be the first item in the list of environment variables (it will often not be).Test Plan
This needs to be manually tested in affected environments to confirm it works.
Testing should be as simple as copying the version of the edit-config script from the PR branch to the expected location in the test environment and running it there.
Additional Information
Fixes: #16819