Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add openSUSE Tumbleweed to CI and packages. #16869

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ferroin
Copy link
Member

@Ferroin Ferroin commented Jan 29, 2024

Summary

Due to issues in the upstream handling of certain packages (namely, certain packages can’t actually be upgraded in openSUSE Docker containers because they blindly assume certain constraints that are not met there), we previously had to remove Tumbleweed from CI.

This PR re-adds Tumbleweed, with the following caveats:

  • It will be skipped for most of our build CI, because there’s no good way for us to reliably work around the issues with package upgrades in our regular build CI (both due to how we have it structured and due to limitations in GitHub Actions).
  • For package builds, the openSUSE handling code in the test scripts used to check the built packages have been updated to mitigate the issue in question.
Test Plan

CI passes on this PR.

The mitigations for the package testing code cannot be fully tested without the problematic situation occurring in the first place and it’s not really possible to predict when it will come up, so there’s not a good way to test them.

@Ferroin
Copy link
Member Author

Ferroin commented Feb 5, 2024

Rebased to pick up latest changes in master.

@tkatsoulas
Copy link
Contributor

tkatsoulas commented Feb 6, 2024

One reason that the build fails is that the gcc compiler of package builder (Tumbleweed) does not provide the fstack_protector for the C language. Checking it more

Edited: w8 I am not 100% sure about this commend

@Ferroin
Copy link
Member Author

Ferroin commented Feb 9, 2024

Rebased to pick up latest changes.

@Ferroin
Copy link
Member Author

Ferroin commented Feb 14, 2024

Rebased again to pick up latest changes.

@Ferroin
Copy link
Member Author

Ferroin commented Mar 22, 2024

Rebased to pick up the latest changes in master (in particular, the protobuf changes).

@Ferroin
Copy link
Member Author

Ferroin commented Jun 7, 2024

Rebased to pick up the latest changes (including a fix for Protobuf/Abseil handling that should make this finally work).

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Jun 7, 2024
This seems to be required to get openSUSE Tumbleweed to handle them
properly when installed from a local directory.
This is needed to make the install work properly on openSUSE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants