respect log level for all sources #16922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are two things in the logging library that are not documented and I believe are not bugs, but are implemented for a reason:
I think I understand 1. - we don't want to filter health (alerts transitions) and access sources (web server access logs) if the global log level is < info. But I think we should respect the log levels of each source when explicitly set (2.).
The issue is reported on Discord.
This PR changes both 1 and 2: both global and individual log levels apply to all sources.
Test Plan
Set access log level, check logs.
Additional Information
For users: How does this change affect me?