Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the duration is not negative #16931

Merged
merged 1 commit into from Feb 5, 2024
Merged

Make sure the duration is not negative #16931

merged 1 commit into from Feb 5, 2024

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Feb 5, 2024

Summary
  • Add a check to prevent negative duration of an alert. This may result to an overflow ending up in 4294967295

@stelfrag stelfrag marked this pull request as ready for review February 5, 2024 11:06
thiagoftsm
thiagoftsm approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected, on Slackware and FreeBSD, LGTM!

@stelfrag stelfrag merged commit be23c6a into netdata:master Feb 5, 2024
132 checks passed
@stelfrag stelfrag deleted the add_alert_duration_check branch February 5, 2024 12:55
@stelfrag stelfrag mentioned this pull request Feb 12, 2024
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 17, 2024
@bmwiedemann
Update netdata to version 1.44.3 / rev 48 via SR 1158803
183f04d 
https://build.opensuse.org/request/show/1158803
by user mia + anag+factory
- Update to 1.44.3 (go.d.plugin 0.58.1)
  See https://github.com/netdata/go.d.plugin/tree/v0.58.1
  and https://github.com/netdata/go.d.plugin/tree/v0.58.0
  * Improved handling of slow queries and CPU usage of the ACLKSYNC
    thread.
    gh#netdata/netdata#16838
  * Improved error handling for listen bind failures. Instead of
    terminating fatally, Netdata now exits gracefully.
    gh#netdata/netdata#16937
  * Fixed invalid alert durations in health log entries.
    gh#netdata/netdata#16931
  * Fixed a race condition during analytics data setup, preventing
    potential Netdata crashes.
    gh#netdata/netdata#16929
  * - Changes in 1.44.2
  * Fixed an inconsistency where the NETDATA_LOG_LEVEL environment
    variable did not affect log level in Docker containers.
    gh#netdata/netdata#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

Assignees
No one assigned
Labels
area/health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stelfrag @thiagoftsm