Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners and cleanup .gitignore #16946

Merged
merged 2 commits into from Feb 6, 2024
Merged

Conversation

vkalintiris
Copy link
Contributor

Summary

SSIA.

Test Plan
  • CI jobs

@vkalintiris vkalintiris added the area/build Build system (autotools and cmake). label Feb 6, 2024
@vkalintiris vkalintiris self-assigned this Feb 6, 2024
@github-actions github-actions bot added area/ci area/database and removed area/build Build system (autotools and cmake). labels Feb 6, 2024
@ilyam8
Copy link
Member

ilyam8 commented Feb 6, 2024

@vkalintiris please add labeler config changes from #16945

@thiagoftsm
Copy link
Contributor

Hello @vkalintiris ,

After to compile this PR, I have the following output when I run git status:

bash-5.2$ git status
On branch pr16946
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Makefile
        aclocal.m4
        autom4te.cache/
        claim/
        collectors/Makefile
        collectors/apps.plugin/Makefile
        collectors/cgroups.plugin/Makefile
        collectors/charts.d.plugin/Makefile
        collectors/cups.plugin/Makefile
        collectors/debugfs.plugin/Makefile
        collectors/diskspace.plugin/Makefile
        collectors/ebpf.plugin/Makefile
        collectors/freebsd.plugin/Makefile
        collectors/freeipmi.plugin/Makefile
        collectors/idlejitter.plugin/Makefile
        collectors/ioping.plugin/Makefile
        collectors/log2journal/Makefile
        collectors/macos.plugin/Makefile
        collectors/nfacct.plugin/Makefile
        collectors/perf.plugin/Makefile
        collectors/plugins.d/Makefile
        collectors/proc.plugin/Makefile
        collectors/python.d.plugin/Makefile
        collectors/slabinfo.plugin/Makefile
        collectors/statsd.plugin/Makefile
        collectors/systemd-journal.plugin/Makefile
        collectors/tc.plugin/Makefile
        collectors/timex.plugin/Makefile
        collectors/xenstat.plugin/Makefile
        compile
        config.guess
        config.h
        config.status
        config.sub
        configure
        daemon/
        database/
        depcomp
        diagrams/Makefile
        exporting/
        health/Makefile
        health/notifications/Makefile
        install-sh
        libnetdata/
        logsmanagement/
        missing
        registry/
        spawn/
        stamp-h1
        streaming/
        system/Makefile
        tests/Makefile
        tests/bugs_example/
        web/Makefile
        web/api/Makefile
        web/api/badges/Makefile
        web/api/exporters/Makefile
        web/api/exporters/prometheus/Makefile
        web/api/exporters/shell/Makefile
        web/api/formatters/Makefile
        web/api/formatters/csv/Makefile
        web/api/formatters/json/Makefile
        web/api/formatters/ssv/Makefile
        web/api/formatters/value/Makefile
        web/api/health/Makefile
        web/api/ilove/Makefile
        web/api/queries/Makefile
        web/api/queries/average/Makefile
        web/api/queries/countif/Makefile
        web/api/queries/des/Makefile
        web/api/queries/incremental_sum/Makefile
        web/api/queries/max/Makefile
        web/api/queries/median/Makefile
        web/api/queries/min/Makefile
        web/api/queries/percentile/Makefile
        web/api/queries/ses/Makefile
        web/api/queries/stddev/Makefile
        web/api/queries/sum/Makefile
        web/api/queries/trimmed_mean/Makefile
        web/gui/Makefile
        web/gui/dashboard/
        web/gui/v1/Makefile
        web/gui/v2/Makefile
        web/rtc/Makefile
        web/server/Makefile
        web/server/static/Makefile

nothing added to commit but untracked files present (use "git add" to track)

I suppose some of these files should not be in this list.

Best regards!

@ilyam8
Copy link
Member

ilyam8 commented Feb 6, 2024

@thiagoftsm keep your repo up to date and clean.

@ilyam8
Copy link
Member

ilyam8 commented Feb 6, 2024

@vkalintiris I think there are more leftovers in .gitignore, for instance:

  • all system/ entries.
  • all health/, claim/ and collectors/ entries.

There is more!

@thiagoftsm
Copy link
Contributor

@thiagoftsm keep your fork up to date and clean.

hub was not doing what I expected. :/

@ilyam8 ilyam8 merged commit 2544e0a into netdata:master Feb 6, 2024
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants