change edac ecc errors from incremental to absolute #16970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/health
area/collectors
ilyam8
force-pushed
the
fix-collectors-make-ecc-errors-absolute
branch
from
cb3c1e1
to
5fd8b46
Compare
ilyam8
force-pushed
the
fix-collectors-make-ecc-errors-absolute
branch
from
5fd8b46
to
e55e65a
Compare
thiagoftsm
approved these changes
Feb 8, 2024
|
Thanks! |
|
@k0ste no, but I think we will have v1.45.0 soon. In two weeks I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #16969
This PR changes the following metrics from incremental to absolute:
mem.edac_mc: correctable/uncorrectable for each Memory Controller.mem.edac_mc_dimm: correctable/uncorrectable for each DIMM module.See the reasoning in #16969. I am inclined to agree that it is incorrect to have them incremental. Because of this, I decided to change the existing metrics rather than add new ones. I think we can say that the incremental metric is somewhat of a bug and a misleading metric. If you do not agree, indicate the use case when you need rates.
Netdata aggregates charts by context, so I changed the contexts to avoid incorrect aggregation. I don't think there's a way around. Again, did that because I thought of it as a bug.
Test Plan
Install, check charts and alarms.
Additional Information
For users: How does this change affect me?