Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect machine GUID change #16979

Merged
merged 1 commit into from Feb 11, 2024

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Feb 9, 2024

Summary

Currently, if you copy the entire /var/cache/netdata folder to a newly installed agent and then start the agent, the new system will use the existing history by switching the parent agent found in the metadata to the newly installed agent. In essence, the historical data from the old system is inherited by the new system.

With this change, the parent found in the copied data will be switched to an archived child node.

Test Plan
  • Install a new agent (A) but don't start it
  • Stop an existing agent (B) and copied it's /var/cache/netdata to agent (A)
  • Start agent (A)
    • You should see data being collected for A
    • You should have an archived child with data from B

@stelfrag stelfrag marked this pull request as ready for review February 10, 2024 08:39
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected, LGTM!

@stelfrag stelfrag merged commit 128ba95 into netdata:master Feb 11, 2024
131 checks passed
@stelfrag stelfrag deleted the detect_machine_guid_change branch February 11, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants