Move diagrams/ under docs/ #16998
Merged
Move diagrams/ under docs/ #16998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkalintiris
requested review from
Ferroin,
tkatsoulas,
novykh and
Ancairon
as code owners
|
@Ancairon I need your review for this one, because I don't know if it's okay to add non-readme files under docs/. |
|
it should be fine, have you checked for any links pointing to these diagrams in here? |
Yes, I found only the ones I updated at https://github.com/netdata/netdata/pull/16998/files#diff-f190a531992718e98b3a16f3de388ff93df6a857692b501e26c403b1bd32bd58 |
|
@netdata/product do we use these diagrams anywhere? From what I know, we don't. I approve this |
Ancairon
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SSIA.
Test Plan