Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watcher thread to report shutdown steps. #17010

Merged
merged 2 commits into from Feb 26, 2024

Conversation

vkalintiris
Copy link
Contributor

Summary
  • Will add a timeout wait for completions in a follow up PR.
Test Plan
  • CI jobs.
  • Build with/without DBENGINE and with/without a normal exit code. The agent should stop running in all cases.
Additional Information

The main drawback of this approach is that the number of steps is fixed and they have to be reported regardless of whether the actually occur in the code path when exiting.

However, this complication only occurs once when we decided how to shutdown the agent based on the ret code and whether dbengine is enabled/disabled.

@vkalintiris vkalintiris self-assigned this Feb 14, 2024
@github-actions github-actions bot added area/daemon area/build Build system (autotools and cmake). labels Feb 14, 2024
@vkalintiris vkalintiris changed the title Bump Add watcher thread to report shutdown steps. Feb 14, 2024
@vkalintiris
Copy link
Contributor Author

@stelfrag Marked as draft because I want your feedback on whether the high-level design is ok or not.

@vkalintiris vkalintiris marked this pull request as ready for review February 22, 2024 09:50
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My doubt is not a blocker, so I am approving the PR to avoid block next steps.
PR is working as expected, LGTM!

@vkalintiris vkalintiris merged commit 5f68469 into netdata:master Feb 26, 2024
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake). area/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants