Update functions tables docs #17071
Merged
Update functions tables docs #17071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/collectors
|
@car12o this file is not on Learn currently, I get this is a docs update and I'm reviewer, do you want to add it in Learn? |
I don't think we should add this to learn for now. |
Ancairon
reviewed
Mar 11, 2024
Comment on lines
129
to
131
| ### ${\color{yellow}IMPORTANT}$ | ||
|
|
||
| On Data values, `timestamp` column value must be in unix micro. |
There was a problem hiding this comment.
Suggested change
| ### ${\color{yellow}IMPORTANT}$ | |
| On Data values, `timestamp` column value must be in unix micro. | |
| > **Important Note** | |
| > | |
| > On Data values, `timestamp` column value must be in unix micro. |
There was a problem hiding this comment.
changed, although I think it will remove the emphasis it should have
There was a problem hiding this comment.
If you want to have it as it was go for it, if this is not in Learn I won't gatekeep it, it's just that yellow was not looking good, and the preview style was odd to me
Ancairon
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update functions tables docs