Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix discovered config default values #17115

Merged

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 6, 2024

Summary

Job charts created from discovered (local listeners) configs have priority 0 because default configuration settings are not applied. This PR fixes it.

Test Plan

Before

DBG jobmgr/manager.go:293 creating ntpd[local] job, config: map[__provider__:sd:net_listeners __source__:discoverer=net_listeners,host=localhost,file=/opt/netdata/usr/lib/netdata/conf.d/go.d/sd/net_listeners.conf __source_type__:discovered address:127.0.0.1:123 collect_peers:false module:ntpd name:local] component="job manager"

After

DBG jobmgr/manager.go:293 creating ntpd[local] job, config: map[__provider__:sd:net_listeners __source__:discoverer=net_listeners,host=localhost,file=/opt/netdata/usr/lib/netdata/conf.d/go.d/sd/net_listeners.conf __source_type__:discovered address:127.0.0.1:123 autodetection_retry:0 collect_peers:false module:ntpd name:local priority:70000 update_every:1] component="job manager
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/go.d.plugin area/go labels Mar 6, 2024
@ilyam8 ilyam8 force-pushed the fix-go.d.plugin-conf-defaults-discovered branch from 0cb844e to ad9aa76 Compare March 6, 2024 08:47
@ilyam8 ilyam8 merged commit 65f9cc2 into netdata:master Mar 6, 2024
133 checks passed
@ilyam8 ilyam8 deleted the fix-go.d.plugin-conf-defaults-discovered branch March 6, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection area/go collectors/go.d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant