Install the correct service file based on systemd version #17159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
github-actions
bot
added
the
area/packaging
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Ferroin
approved these changes
Mar 14, 2024
ilyam8
reviewed
Mar 14, 2024
| ifeq ($(shell test $(SYSTEMD_VERSION) -ge 235 && echo "1"), 1) | ||
| SYSTEMD_UNIT = $(BUILDDIR)/system/systemd/netdata.service.v235 | ||
| else | ||
| ifeq ($(shell test $(SYSTEMD_VERSION) -gt 235 && echo "1"), 1) |
There was a problem hiding this comment.
Probably using -le here is better because if the command fails we will install $(BUILDDIR)/system/systemd/netdata.service instead of the old one - this is the logic we use in install_systemd_service().
@netdata/agent-sre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?