DBENGINE: support ZSTD compression #17244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsaou
requested review from
Ferroin,
vkalintiris and
thiagoftsm
as code owners
github-actions
bot
added
area/database
area/build
…d pages if compression fails or generates bigger data
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Mar 26, 2024
* extract dbengine compression to separate files * added ZSTD support in dbengine * automatically select best compression * handle decompression errors * eliminate fatals from compression algorithms; fallback to uncompressed pages if compression fails or generates bigger data * have the unit test generate many data files (cherry picked from commit f1c26d0)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Mar 27, 2024
* extract dbengine compression to separate files * added ZSTD support in dbengine * automatically select best compression * handle decompression errors * eliminate fatals from compression algorithms; fallback to uncompressed pages if compression fails or generates bigger data * have the unit test generate many data files (cherry picked from commit f1c26d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statistics:
Using the samples of the dbengine unit test.
The number of samples generated are 184549376 (about 185 million).
Keep in mind that these are incremental values, that are optimal for gorilla compression. However it is prominent that gorilla pages are compressed much higher than raw samples.
In practice, Netdata can achieve 0.6 bytes per sample on the second row (Array 32-bit with LZ4). We need to see in practice what is going to happen with the last one!
Also, the unit test runs faster with gorilla. I guess Gorilla improves significantly the memory bandwidth required or the CPU cache efficiency.