Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect to the cloud when resuming from suspension #17444

Merged
merged 1 commit into from Apr 19, 2024
Merged

Reconnect to the cloud when resuming from suspension #17444

merged 1 commit into from Apr 19, 2024

Conversation

stelfrag
Copy link
Collaborator

Summary
  • If resume from suspension is detected, schedule an node update to revive the connection

@stelfrag stelfrag marked this pull request as ready for review April 18, 2024 13:58
thiagoftsm
thiagoftsm approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected, LGTM!

ilyam8
ilyam8 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@ilyam8 ilyam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS (me) and Linux laptops (@Ancairon) - fixed. Thanks!

@ilyam8 ilyam8 merged commit 0b8386e into netdata:master Apr 19, 2024
152 of 153 checks passed
@stelfrag stelfrag deleted the cloud_reconnect branch April 22, 2024 08:17
stelfrag added a commit to stelfrag/netdata that referenced this pull request May 1, 2024
@stelfrag
Reconnect to the cloud when resuming from suspension (netdata#17444)
4d8d6f6 
(cherry picked from commit 0b8386e)
@stelfrag stelfrag mentioned this pull request May 1, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees
No one assigned
Labels
area/health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stelfrag @ilyam8 @thiagoftsm