Add option to limit architectures for offline installs. #17604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default behavior will still be to download all supported architectures (because there _will_ be stupid users who do not pay attention to matching architectures between the system used to prepare the installl source and the system where they are actually installing), but this will allow those who know what they’re doing to just prepare things for a specific target system.
github-actions
bot
added
the
area/packaging
ilyam8
reviewed
May 7, 2024
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
ilyam8
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Default behavior will still be to download all supported architectures (because there will be users who do not pay attention to matching architectures between the system used to prepare the installl source and the system where they are actually installing), but this will allow those who know what they’re doing to just prepare things for a specific target system.
The new option is called
--offline-architecture. It can be specified multiple times (in which case it will result in the full set of architectures being used), and will throw a fatal error if an unrecognized value is passed.Test Plan
Requires manual local testing of the
--prepare-offline-install-sourceoption with and without the new option.