Improve handling of an alert that transitions to the REMOVED state #17621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
approved these changes
May 9, 2024
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
May 17, 2024
…etdata#17621) (cherry picked from commit f51f457)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a claimed parent and child agent setup, when a child disconnects, all the child's alerts are removed. Up until now the REMOVED alert transition was not submitted to the cloud. This can result in an inconsistency when viewing alerts on the cloud dashboard.
This PR changes this behavior to send the REMOVED alert transition to the cloud if previous status of the alert is WARNING or CRITICAL.