Correctly handle required compilation flags for dependencies. #17664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`target_compile_definitions` can only be used for actual command line _macro definitions_. But the `*_CFLAGS_OTHER` may contain flags that are _not_ macro definitions, and when that happens, any use of `target_compile_definitions` with the relevant `*_CFLAGS_OTHER` variable will break the build. Instead, we should be using `target_compile_options` for these variables.
github-actions
bot
added
area/packaging
vkalintiris
approved these changes
May 16, 2024
Merged
Ferroin
added a commit
to stelfrag/netdata
that referenced
this pull request
May 20, 2024
…a#17664) `target_compile_definitions` can only be used for actual command line _macro definitions_. But the `*_CFLAGS_OTHER` may contain flags that are _not_ macro definitions, and when that happens, any use of `target_compile_definitions` with the relevant `*_CFLAGS_OTHER` variable will break the build. Instead, we should be using `target_compile_options` for these variables.
Ferroin
added a commit
that referenced
this pull request
May 21, 2024
`target_compile_definitions` can only be used for actual command line _macro definitions_. But the `*_CFLAGS_OTHER` may contain flags that are _not_ macro definitions, and when that happens, any use of `target_compile_definitions` with the relevant `*_CFLAGS_OTHER` variable will break the build. Instead, we should be using `target_compile_options` for these variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
target_compile_definitionscan only be used for actual command line macro definitions. But the*_CFLAGS_OTHERmay contain flags that are not macro definitions, and when that happens, any use oftarget_compile_definitionswith the relevant*_CFLAGS_OTHERvariable will break the build.Instead, we should be using
target_compile_optionsfor these variables.Test Plan
Observe that the CI jobs for Rocky Linux 8 and CentOS 8 Stream pass on this PR, despite failing on the master branch.