Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timex slow shutdown #17688

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix timex slow shutdown #17688

merged 1 commit into from
May 17, 2024

Conversation

stelfrag
Copy link
Collaborator

Summary
  • Sleep per second and iterate as needed (be more responsive during shutdown)

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/timex labels May 16, 2024
@stelfrag stelfrag marked this pull request as ready for review May 16, 2024 20:04
@stelfrag stelfrag requested a review from thiagoftsm as a code owner May 16, 2024 20:04
thiagoftsm
thiagoftsm approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving considering that an analogous logic is used in eBPF plugin, and it also solved the same issue. LGTM!

@stelfrag stelfrag merged commit 9fd7845 into netdata:master May 17, 2024
148 of 149 checks passed
@stelfrag stelfrag deleted the fix_timex_shutdown branch May 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagoftsm thiagoftsm thiagoftsm approved these changes

Assignees
No one assigned
Labels
area/collectors Everything related to data collection collectors/timex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stelfrag @thiagoftsm